microsoft

@microsoft-github-policy-service agree

Note on test failure

The failure appears unrelated to the bilinear changes. The error is raised during test input generation for upsample_bilinear2d_* in full-graph mode
(ValueError: Seed must be between 0 and 2**32 - 1).

This suggests an RNG seed issue in the test harness rather than an op
implementation problem. I can reproduce it consistently locally.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.11%. Comparing base (72321e5) to head (292b8eb).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #2746   +/-   ##
=======================================
  Coverage   70.10%   70.11%           
=======================================
  Files         228      228           
  Lines       27387    27396    +9     
  Branches     2785     2785           
=======================================
+ Hits        19201    19210    +9     
  Misses       7227     7227           
  Partials      959      959           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Hey @justinchuby! I fixed the batch-dim issue by switching to Shape(input1, start=0, end=-1) so all leading dims are preserved (the op requires identical batch shapes anyway).

Tests still intermittently fail due to the existing RNG seed issue (same as the upsample_bilinear2d tests), which seems unrelated to this change.

To better guard against regressions here, would you like me to add a test case for bilinear with batch_dim > 1? I can do that in a follow-up PR if that’s preferable.

To better guard against regressions here, would you like me to add a test case for bilinear with batch_dim > 1? I can do that in a follow-up PR if that’s preferable.

That would be ideal, thanks! Yes a follow up PR is preferable.

Thank you!

same as well chief